Skip to content

#1429 fix added in 1 px to fix height issue in toc #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

#1429 fix added in 1 px to fix height issue in toc #1438

merged 1 commit into from
Jul 18, 2019

Conversation

ChrisHillCap
Copy link
Contributor

@ChrisHillCap ChrisHillCap commented Jul 17, 2019 •
edited
Loading

Firefox example of fix
FirefoxFix
Chrome example of fix
ChromeFix

fixes issue #1429

@exoego
Copy link
Contributor

exoego commented Jul 17, 2019

LGTM 👍

@dongxuwang dongxuwang self-requested a review July 18, 2019 01:07
dongxuwang
dongxuwang approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@dongxuwang dongxuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SethTisue SethTisue merged commit 90fa1d5 into scala:master Jul 18, 2019
@SethTisue
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongxuwang dongxuwang dongxuwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisHillCap @exoego @SethTisue @dongxuwang